Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PAYG instructions to v2.8 #1374

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

LucasSaintarbor
Copy link
Contributor

Fixes #[issue_number]

Reminders

  • See the README for more details on how to work with the Rancher docs.

  • Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.

  • If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.

Description

Comments

@LucasSaintarbor
Copy link
Contributor Author

@jeremy-moffitt Referring to #1354, should we recommend users be on Rancher v2.8.4? Should the v2.7 docs be kept or removed? (https://ranchermanager.docs.rancher.com/v2.7/integrations-in-rancher/cloud-marketplace/cloud-marketplace-payg-integration)

@jeremy-moffitt
Copy link

Regarding 2.7 support, any existing customers running PAYG on 2.7 are still in support and do not have to migrate, so I'm hesitant to remove the 2.7 docs at this point. We could add a note indicating the listings have been updated to 2.8.4 and customers are encouraged to remain current with the listing to get the latest features and security fixes.

@jeremy-moffitt Referring to #1354, should we recommend users be on Rancher v2.8.4? Should the v2.7 docs be kept or removed? (https://ranchermanager.docs.rancher.com/v2.7/integrations-in-rancher/cloud-marketplace/cloud-marketplace-payg-integration)

@jeremy-moffitt
Copy link

@LucasSaintarbor anything you need from me or my team on this? We'll be starting the updates to 2.9.1 in a couple weeks so we'll have a new request... for now the 2.8.4 info is current.

@LucasSaintarbor
Copy link
Contributor Author

@LucasSaintarbor anything you need from me or my team on this? We'll be starting the updates to 2.9.1 in a couple weeks so we'll have a new request... for now the 2.8.4 info is current.

Hey @jeremy-moffitt, sorry for the late reply. May you review my latest update (393aac0)?

@LucasSaintarbor LucasSaintarbor marked this pull request as ready for review September 6, 2024 17:31
jeremy-moffitt
jeremy-moffitt previously approved these changes Sep 6, 2024
Copy link

@jeremy-moffitt jeremy-moffitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content changes look good to me. The verbiage around versions is clear and makes sense. Thanks for making the update!

@jeremy-moffitt
Copy link

Please let me know if I need to track down another reviewer from my team. I'm assuming one of the doc writers will perform a review aimed at catching non-content issues. Thanks.

Copy link
Contributor

@martyav martyav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked at the new Supported Versions blurb as I'm trusting (for now) that the v2.8 pages are a straight copy-paste of v2.7 and have already been reviewed in previous PRs. I edited the new section for brevity and put the v2.8 rec more forward, so it's clear to users what version they should use

Co-authored-by: Marty Hernandez Avedon <[email protected]>
…tplace/cloud-marketplace-payg-integration.md

Co-authored-by: Marty Hernandez Avedon <[email protected]>
@jeremy-moffitt
Copy link

FYI, the AWS Rancher PAYG listings are now up to 2.9.1, with Azure to follow shortly.

@jeremy-moffitt
Copy link

Azure is stuck on 2.8.4 for now, but per my previous comment AWS is updated to 2.9.1... let me know if you need more info for the doc update. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants